My goal is to commit changes to my application, create a PR, and merge to main.
I am currently on a branch. I just committed app changes to that branch. I have a dependent workflow (wfABC) that was also âprotectedâ at the same time I introduced âprotectionâ to the app. That workflow depends on a number of workflow âbelowâ it (ie wfRST, wfUVW), so âprotectionâ was also added to them at the same time.
I have made changes to the dependent workflow, wfABC but not to any of the other workflows (ie wfRST, wfUVW). However, when I go to create the pull request from the app (after committing changes to the app and wfABC), it shows (ie wfRST, wfUVW) as having âuncomitted changesâ even though no changes were made. To confirm, I opened the corresponding workflows and viewed the diff (under the commit button), and there are indeed no changes.
So I have 2 questions:
When trying to create an app pull request, why is Retool telling me there are uncomitted changes to a workflow, when no changes have been made?
Going back to when I first setup app âprotectionâ â I remember seeing a notice in the process of protecting, or maybe it was in the docs, something about âwhen an app depends on a workflow, the workflow will initially be committed along with the app. however, changes to the workflow will not be represented in source control / pull requests / commits / whateverâ. â- This also seems to contradict what Retool is telling me now, that there are uncommitted changes on a workflow.
1. Retool is showing the dependent workflows as âuncommitted changesâ because when protection or dependencies update, Retool changes some hidden internal metadata inside those workflows. The actual workflow logic hasnât changed, so the diff is empty, but the metadata change still makes Retool mark them as modified.
2. This doesnât conflict with the message that workflow logic wonât appear in commits. The workflow code is not being committed â only the hidden metadata gets updated in the background. Thatâs why Retool still shows uncommitted changes even though the visible workflow code didnât change.
If no workflows have changed, and I commit a change to the app and create a pull request, can I safely ignore the warning that my dependent workflows have uncommitted changes or do I need to create a commit for each of them (since I canât create a single commit for everything at once)? In this specific case, I have about 8 workflows that are showing âuncommitted changesâ and itâd be annoying to have to create 8 additional commits every time I create a new PR for the app itself.
Yes, you can safely ignore those warnings. Since the workflows didnât actually change, Retool is only showing metadata updates, not real edits. You donât need to create 8 separate commits every time just commit your app changes and continue.
I created a PR for my app changes. I had changes in a dependent workflow, and committed those too. When I view the PR, I see workflow changes in there. Based on the original verbiage, I thought workflow changes would not be reflected in app PRs?! Did I miss something?
@lkiss The message only means that normal workflow logic doesnât get bundled automatically when you commit an app. But if you manually commit a workflow, then Retool treats it like any other change so it will show up in the PR.
So in your case, since you committed the workflow yourself, those changes will appear in the app PR. Thatâs expected.