Github deployment bug with unassigned resource query

in a protected app in our dev environment, I created a resource query and then never selected a resource. I accidentally left this in when I committed my changes and then merged them into the main branch. This causes the automated deployment to fail. This caused some issues when trying to revert to the previous commit for some reason, although that may have been my fault. Committing a resource query without an associated resource should be blocked, or the deployment bot should be able to handle deploying it.

Thanks for flagging this, @aharmange! I like the idea of blocking the commit if we detect breaking changes, but that hinges on already knowing what constitutes a breaking change. :thinking: You've discovered at least one of them!

I'll talk to our team here about how we might be able to implement this. At the very least, we can address this particular issue. I'll keep this topic updated as the conversation progresses!

Hey @aharmange - hope all is well! I'm not having any luck reproducing this particular issue on a cloud instance.

Are you running a self-hosted instance, perchance? If so, which version?

Hi @Darren sorry- I should have specified in the original post that this is on self hosted retool, version 3.52.1

Ah no worries! That makes sense. :+1:

I'm able to reproduce this now. Given the fact that I was unable to do so on Cloud, I'm guessing that this particular issue has been fixed. If I'm able to figure out which version contains a fix, would your org be able to upgrade?

yes, we should probably upgrade to the latest version anyways, so if it's fixed in the latest release then I'll just go ahead and upgrade it soon so that this won't happen again. Thanks for looking into it!

1 Like

Of course! I checked and it looks like it was actually fixed in version 3.52.2. :sweat_smile: Definitely recommend upgrading to something more recent, though!

1 Like